Add missing hops in traceroute as "unknown" nodes #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. in case a node couldn't decrypt the packet
thebentern
approved these changes
Jun 9, 2024
This was referenced Jun 9, 2024
slash-bit
pushed a commit
to slash-bit/meshtastic-echo-echo
that referenced
this pull request
Jul 4, 2024
E.g. in case a node couldn't decrypt the packet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3942.
Using
hopStartandhopLimit, missing hops in a traceroute (e.g. when a node cannot decrypt it) can be detected. In this case, the node receiving it afterwards adds dummy node numbers (0xFFFFFF) to the route, which will be shown as “Unknown Username” in the apps.It shows as follows in the logs: