Let StoreForward server send history to phoneAPI #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Jul 13, 2024
|
Super cool! |
|
Can we make it not function on the default key? |
|
Okay, I can add that restriction for the request over LoRa. Would need to be added to the docs as well then. |
|
Latest commit adds the restriction. |
thebentern
approved these changes
Jul 13, 2024
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a node configured as StoreForward server to use its PSRAM for an extended text message history (max. ~11,000) for sending to a connected client app. When connecting to the server, you automatically get the packets you missed since the last connection. Text messages will not be placed in the
toPhoneQueueanymore to avoid duplicates and have more room for other packets.It ended up being quite a redesign of the StoreForwardModule to remove the
packetHistoryTXQueuewhich could become quite large and was actually just a filtered duplicate. Instead, we just loop through thepacketHistoryitself.I also automatically set the new
is_serverconfiguration to true for nodes that wereROUTER_CLIENTand had the StoreForwardModule enabled, because that was the previous behavior. If that's not desired I can remove it.