Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work for Heltec Vision Master 213 #4286

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Conversation

todd-herbert
Copy link
Contributor

Debug logs

  • CDC on boot (E213)
  • Correct hardware ids (E213)

I2C

  • Correct pins (E213)

Buttons

  • Remap user button to "outermost" (E213, E290)

HarukiToreda and others added 5 commits July 14, 2024 00:32
* Fix for serial monitoring and I2C

The board did not allow serial monitoring while on boot mode, i was able to fix this by adding a board variant. I also corrected the i2c pins. I was able to test it with a cardkb

* oops

I delete some code by mistake, all back now

* Made some adjustments

* Minimize the diff

---------

Co-authored-by: Todd Herbert <[email protected]>
Suppresses compiler warnings
Less chance of accidentally hitting reset
Allows upload without manually entering bootloader
@todd-herbert todd-herbert requested a review from thebentern July 13, 2024 14:29
@todd-herbert todd-herbert marked this pull request as draft July 13, 2024 18:23
@todd-herbert todd-herbert marked this pull request as ready for review July 13, 2024 18:24
@todd-herbert
Copy link
Contributor Author

todd-herbert commented Jul 13, 2024

Apparently a different issue with I2C timing is coming up for CardKB. Don't want the other commits to miss the next alpha though.

@thebentern thebentern merged commit 3fa8b35 into master Jul 13, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants