Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new defaults #4294

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Migrate to new defaults #4294

merged 6 commits into from
Jul 16, 2024

Conversation

thebentern
Copy link
Contributor

No description provided.

@thebentern thebentern requested a review from todd-herbert July 15, 2024 23:42
@thebentern thebentern marked this pull request as ready for review July 16, 2024 00:04
Copy link
Contributor

@todd-herbert todd-herbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't built it for a test run, but I can in a few hours if it helps.

From a read through it looks good!

  • module config won't be erased, because DEVICESTATE_MIN_VER remains unchanged
  • module config will be updated on first boot, because DEVICE_STATE_CUR_VER has increased
  • module config won't be updated on every boot, because moduleConfig.version is increased to DEVICE_STATE_CUR_VER after the initial update

src/mesh/NodeDB.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@todd-herbert todd-herbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave this a run on T-Beam and caught something unexpected.
It seems like NodeDB::initModuleConfigIntervals is using default_broadcast_interval_secs, which is defined as 900 seconds.

@thebentern
Copy link
Contributor Author

I just gave this a run on T-Beam and caught something unexpected. It seems like NodeDB::initModuleConfigIntervals is using default_broadcast_interval_secs, which is defined as 900 seconds.

Wowie! How did I miss that land mine?!
I think I'll zero those out so that they coalesce into my getConfiguredOrDefault() so we can move the defaults around again on those who don't set it to a different value.

@thebentern thebentern requested a review from todd-herbert July 16, 2024 12:21
@thebentern thebentern merged commit 46d7b82 into master Jul 16, 2024
95 checks passed
@caveman99 caveman99 deleted the migrate-to-new-defaults branch August 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants