-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new defaults #4294
Migrate to new defaults #4294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't built it for a test run, but I can in a few hours if it helps.
From a read through it looks good!
- module config won't be erased, because
DEVICESTATE_MIN_VER
remains unchanged - module config will be updated on first boot, because
DEVICE_STATE_CUR_VER
has increased - module config won't be updated on every boot, because
moduleConfig.version
is increased toDEVICE_STATE_CUR_VER
after the initial update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just gave this a run on T-Beam and caught something unexpected.
It seems like NodeDB::initModuleConfigIntervals
is using default_broadcast_interval_secs, which is defined as 900 seconds.
Wowie! How did I miss that land mine?! |
No description provided.