Set PIN_3V3_EN to HIGH (nrf52_promicro_diy variants) #4321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missed 3v3 pin initialisation for nrf52_promicro_diy variants.
This NRF52 board has vcc pin, which usually powers lora module and sensors.
Old promicro versions has incorrect resistor, so in any PIN_3V3_EN state LDO has enough voltage on EN pin (active state) and custom boards.
New boards has correct resistor value, so PIN_3V3_EN state able to activate/inactivate LDO and it need to be enabled in variant.cpp.