Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PIN_3V3_EN to HIGH (nrf52_promicro_diy variants) #4321

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Set PIN_3V3_EN to HIGH (nrf52_promicro_diy variants) #4321

merged 4 commits into from
Jul 23, 2024

Conversation

mrekin
Copy link
Contributor

@mrekin mrekin commented Jul 23, 2024

Added missed 3v3 pin initialisation for nrf52_promicro_diy variants.
This NRF52 board has vcc pin, which usually powers lora module and sensors.

Old promicro versions has incorrect resistor, so in any PIN_3V3_EN state LDO has enough voltage on EN pin (active state) and custom boards.
New boards has correct resistor value, so PIN_3V3_EN state able to activate/inactivate LDO and it need to be enabled in variant.cpp.

@thebentern thebentern merged commit e27375d into meshtastic:master Jul 23, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants