Fix T1000-E GPS - some changes went missing from #4303? #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Jul 25, 2024
|
@markbirss - this was because of #4319 . The extra baud rate code probably isn't needed anymore, see a few lines down - should automatically get your 115200 since it's set in variant.h. |
Ok, I see, I may have not looked at it long enough 😳 |
fifieldt
pushed a commit
to fifieldt/meshtastic-firmware
that referenced
this pull request
Jul 29, 2024
…shtastic#4328) * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp * Update GPS.cpp
fifieldt
added a commit
to fifieldt/meshtastic-firmware
that referenced
this pull request
Aug 5, 2024
meshtastic#4319 added autodetect code for UC6580, and removed these ifdefs. However, they were inadvertantly re-added by meshtastic#4328 .
Merged
thebentern
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes from @Dylanliacc T1000-E branch went missing in the merge it seems, and GPS is not detected on master
#4303