Fix build to not use incorrect OneButton version #4374
Conversation
OneButton pushed out a new update today that has a different API rather than just use whichever new version they push, stay on 2.5.x until someone sees a need to update. Fixes build for wm1100 tracker.
|
btw @thebentern - I think the reason recent CI builds are now failing is because of this also. |
|
@geeksville yep it definitely is 😅 |
|
ooh I see ! |
|
hmm @thebentern it seems like the platformio version fetching isn't working with their release name for 2.6.1. It only finds 2.6.0 if the platformio.ini file is updated. I think they might have strict rules and https://github.com/mathertel/OneButton/releases botched the name of the release (not calling it literally 2.6.1 but instead 'fixing blah blah). This apparently breaks the github auto version resolution for 'releases' (notice how interestingly https://github.com/mathertel/OneButton says the latest release is 2.6.0 still) |
|
Weird. Perhaps we can just use the github tag? |
OneButton pushed out a new update today that has a different API rather than just use whichever new version they push, stay on 2.5.x until someone sees a need to update. Fixes build for wm1100 tracker.