Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pin modes of selected pins before attempting to write to them in Remote Hardware module #4385

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

Kealper
Copy link
Contributor

@Kealper Kealper commented Aug 4, 2024

This is a small change to properly configure the correct pin mode before attempting to write to the specified pins in the mask in the Remote Hardware module. This change fixes Remote Hardware writes on RP2040-based devices.

Previously, the pin modes were set after the writes had taken place, and it seems like the Arduino core for ESP32 implicitly set the target pin to OUTPUT automagically before writing if it wasn't set prior. This does not appear to be the case with the arduino-pico core so writes to a misconfigured pin would just silently fail.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fifieldt
Copy link
Contributor

fifieldt commented Aug 4, 2024

Nice find!

Copy link
Member

@GUVWAF GUVWAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find indeed!

@thebentern thebentern merged commit 5bbafdf into meshtastic:master Aug 4, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants