Configure pin modes of selected pins before attempting to write to them in Remote Hardware module #4385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to properly configure the correct pin mode before attempting to write to the specified pins in the mask in the Remote Hardware module. This change fixes Remote Hardware writes on RP2040-based devices.
Previously, the pin modes were set after the writes had taken place, and it seems like the Arduino core for ESP32 implicitly set the target pin to
OUTPUT
automagically before writing if it wasn't set prior. This does not appear to be the case with thearduino-pico
core so writes to a misconfigured pin would just silently fail.