Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split factory reset into config and device variants #4427

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Split factory reset into config and device variants #4427

merged 3 commits into from
Aug 9, 2024

Conversation

thebentern
Copy link
Contributor

No description provided.

@thebentern thebentern merged commit 3878e02 into master Aug 9, 2024
99 checks passed
@thebentern thebentern deleted the new-factory-reset-split branch August 9, 2024 13:38
@thebentern
Copy link
Contributor Author

thebentern commented Aug 9, 2024 •
edited
Loading

@garthvh @andrekir @Hunter275 I think most folks will want the existing factory reset function in the apps to send the factory_reset_config now which resets everything except for the BLE bonds.

@ianmcorvidae I think the factory_reset_device additionally makes sense in CLI. I'm wondering if we add an optional argument to the existing command to specify that we're factory reseting the entire device?

andrekir added a commit to meshtastic/Meshtastic-Android that referenced this pull request Aug 18, 2024
@andrekir
refactor: rename admin factory reset method
6d4b0b6 
references:
- meshtastic/protobufs#539
- meshtastic/firmware#4427
danwelch3 pushed a commit to danwelch3/meshtastic-android that referenced this pull request Oct 3, 2024
@andrekir @danwelch3
refactor: rename admin factory reset method
3540d6d 
references:
- meshtastic/protobufs#539
- meshtastic/firmware#4427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thebentern