Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ASCII log option needed by portudino #4443

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

charlieh0tel
Copy link
Contributor

Adds ASCII log option to prevent control characters going into syslog.
This is needed to get reasonable logs for portudino.

@charlieh0tel charlieh0tel force-pushed the charlieh0tel/clean-logs branch 3 times, most recently from c8b3c8b to 1330145 Compare August 12, 2024 03:38
@charlieh0tel charlieh0tel marked this pull request as draft August 12, 2024 16:23
@charlieh0tel charlieh0tel force-pushed the charlieh0tel/clean-logs branch 3 times, most recently from 13a99d0 to 466773e Compare August 13, 2024 20:14
Activates ASCII log option when stdout is not a terminal.  This is
generally the right thing to do; if not, the behavior can be
overridden in config.yaml using AsciiLogs under Logging.  The result
is reasonable system logs for portudino when running under systemd or
the like.

Signed-off-by: Christopher Hoover <[email protected]>

.

.

.
@charlieh0tel charlieh0tel force-pushed the charlieh0tel/clean-logs branch from 466773e to 394b6db Compare August 13, 2024 23:06
@charlieh0tel charlieh0tel marked this pull request as ready for review August 14, 2024 00:56
@charlieh0tel
Copy link
Contributor Author

PTAL.

@jp-bennett
Copy link
Collaborator

PTAL.

I'll give it a closer look and a test run, but looking good.

@jp-bennett
Copy link
Collaborator

@charlieh0tel One last thing. Can you add an AsciiLogs entry to bin/config-dist.yaml, commented out by default?

@charlieh0tel
Copy link
Contributor Author

do i need to rebase this?

@jp-bennett
Copy link
Collaborator

do i need to rebase this?

Nope, this looks good. I'll do a squash and merge once CI finishes.

@jp-bennett jp-bennett merged commit 8517675 into meshtastic:master Aug 16, 2024
100 checks passed
thebentern added a commit that referenced this pull request Aug 16, 2024
* Adds ASCII logs useful to portudino

Activates ASCII log option when stdout is not a terminal.  This is
generally the right thing to do; if not, the behavior can be
overridden in config.yaml using AsciiLogs under Logging.  The result
is reasonable system logs for portudino when running under systemd or
the like.

Signed-off-by: Christopher Hoover <[email protected]>
Co-authored-by: Christopher Hoover <[email protected]>
@charlieh0tel charlieh0tel deleted the charlieh0tel/clean-logs branch November 23, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants