-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ASCII log option needed by portudino #4443
Merged
jp-bennett
merged 4 commits into
meshtastic:master
from
charlieh0tel:charlieh0tel/clean-logs
Aug 16, 2024
Merged
Adds ASCII log option needed by portudino #4443
jp-bennett
merged 4 commits into
meshtastic:master
from
charlieh0tel:charlieh0tel/clean-logs
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieh0tel
force-pushed
the
charlieh0tel/clean-logs
branch
3 times, most recently
from
August 12, 2024 03:38
c8b3c8b
to
1330145
Compare
charlieh0tel
force-pushed
the
charlieh0tel/clean-logs
branch
3 times, most recently
from
August 13, 2024 20:14
13a99d0
to
466773e
Compare
Activates ASCII log option when stdout is not a terminal. This is generally the right thing to do; if not, the behavior can be overridden in config.yaml using AsciiLogs under Logging. The result is reasonable system logs for portudino when running under systemd or the like. Signed-off-by: Christopher Hoover <[email protected]> . . .
charlieh0tel
force-pushed
the
charlieh0tel/clean-logs
branch
from
August 13, 2024 23:06
466773e
to
394b6db
Compare
PTAL. |
I'll give it a closer look and a test run, but looking good. |
@charlieh0tel One last thing. Can you add an AsciiLogs entry to bin/config-dist.yaml, commented out by default? |
do i need to rebase this? |
Nope, this looks good. I'll do a squash and merge once CI finishes. |
thebentern
added a commit
that referenced
this pull request
Aug 16, 2024
* Adds ASCII logs useful to portudino Activates ASCII log option when stdout is not a terminal. This is generally the right thing to do; if not, the behavior can be overridden in config.yaml using AsciiLogs under Logging. The result is reasonable system logs for portudino when running under systemd or the like. Signed-off-by: Christopher Hoover <[email protected]> Co-authored-by: Christopher Hoover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ASCII log option to prevent control characters going into syslog.
This is needed to get reasonable logs for portudino.