Add PKI channel for MQTT #4464
Merged
Add PKI channel for MQTT #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUVWAF
reviewed
Aug 15, 2024
| @@ -161,8 +162,11 @@ void MQTT::onReceive(char *topic, byte *payload, size_t length) | |||
| p->channel = ch.index; | |||
| } | |||
|
|
|||
| // PKI messages get accepted even if we can't decrypt | |||
| if (router && p->which_payload_variant == meshtastic_MeshPacket_encrypted_tag && p->channel == 0) | |||
There was a problem hiding this comment.
Better to check for (strcmp(e.channel_id, "PKI") to avoid not decrypting when you happen to have a channel hash of 0.
Also, I think here we want to check whether the to and from are in our NodeDB to avoid routing PKI messages for nodes that do not talk via your channels.
There was a problem hiding this comment.
Latest change to 2.5 branch fixes all of this, except checking for to/from. I'm still pondering that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are connecting to MQTT, this adds the root/2/e/PKI topic for PKI messages.