Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: default to fuzzy GPS location on the Default Channel #4467

Merged
merged 4 commits into from
Aug 18, 2024
Merged

feature: default to fuzzy GPS location on the Default Channel #4467

merged 4 commits into from
Aug 18, 2024

Conversation

mrfyda
Copy link
Contributor

@mrfyda mrfyda commented Aug 15, 2024

First contribution to the repo, attempting to fix #4412.

The original issue suggested using a default fuzzy location with 700m precision. This pull requests instead is using ~1500m precision which is the same default as for MQTT Map Report module.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thebentern thebentern requested a review from jp-bennett August 15, 2024 13:50
@thebentern thebentern requested a review from garthvh August 15, 2024 13:51
@thebentern
Copy link
Contributor

I think this is a reasonable change. @jp-bennett @garthvh any objections?

@garthvh
Copy link
Member

garthvh commented Aug 15, 2024

I think this is a reasonable change. @jp-bennett @garthvh any objections?

Might be good to target 2.5, the circles may not even be in the play store yet. These imprecise positions just seem wrong without the visualization in place.

@ianmcorvidae
Copy link
Contributor

I have one thought, which is that Android currently has options for 32 (high precision), 16 (medium precision) and 11 (low precision) only, and shows an input box for other options (but only if it's already outside of those three + disabled). I think we should either use one of those here, or (better, IMO) add more options to the default available ones on Android to include 14. Either adding medium-low at 14 (and medium-high, maybe, but 16 is already kinda that), or adding a way to select everything in something like 10-19 or 11-16 or such (whatever range iOS allows, probably).

@thebentern thebentern changed the base branch from master to 2.5-changes August 15, 2024 15:43
@garthvh
Copy link
Member

garthvh commented Aug 15, 2024

I have one thought, which is that Android currently has options for 32 (high precision), 16 (medium precision) and 11 (low precision) only, and shows an input box for other options (but only if it's already outside of those three + disabled). I think we should either use one of those here, or (better, IMO) add more options to the default available ones on Android to include 14. Either adding medium-low at 14 (and medium-high, maybe, but 16 is already kinda that), or adding a way to select everything in something like 10-19 or 11-16 or such (whatever range iOS allows, probably).

iOS does 10...19 for config and map display and defaults to 13. I have code that displays the estimated distance on a slider.

@garthvh
Copy link
Member

garthvh commented Aug 15, 2024

And I chose 13 as the default as it would not be precise geolocation data under the California law.

@garthvh
Copy link
Member

garthvh commented Aug 15, 2024

IMG_3060

@thebentern
Copy link
Contributor

@mrfyda Let's default to 13 since that has a legal basis, and can we get that option added to the android app?@jamesarich

@jamesarich
Copy link

@mrfyda Let's default to 13 since that has a legal basis, and can we get that option added to the android app?@jamesarich

Can we make this an issue on the android repo so it doesn't get lost in the shuffle, pls. Not sure when I'll have some more cycles to burn.

@thebentern
Copy link
Contributor

Can we make this an issue on the android repo so it doesn't get lost in the shuffle, pls. Not sure when I'll have some more cycles to burn.

meshtastic/Meshtastic-Android#1197

@thebentern thebentern changed the base branch from 2.5-changes to master August 18, 2024 12:38
@thebentern thebentern merged commit 7129cee into meshtastic:master Aug 18, 2024
3 checks passed
@akrabu
Copy link

akrabu commented Aug 21, 2024

I haven't tested the alpha firmware yet, but I have noticed on the iOS app that the fuzzy circles can be very... visually noisy and distracting. I can't imagine how messy the map would appear with everyone having fuzzy circles by default.

I'd like to request that the circles only show when a node is tapped on - or at least a way to turn the wider circles off with the options. Thanks!

@garthvh
Copy link
Member

garthvh commented Aug 21, 2024

I haven't tested the alpha firmware yet, but I have noticed on the iOS app that the fuzzy circles can be very... visually noisy and distracting. I can't imagine how messy the map would appear with everyone having fuzzy circles by default.

I'd like to request that the circles only show when a node is tapped on - or at least a way to turn the wider circles off with the options. Thanks!

The whole point is to see at a glance that it is imprecise without having to click on it, the circles are transparent and can overlap fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Please default to fuzzy GPS location on the Default Channel.
8 participants