Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-compute correct timeslot on applyModemConfig #4469

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

thebentern
Copy link
Contributor

Per our conversation in contributors room in Discord
Closes #3892

@GUVWAF
Copy link
Member

GUVWAF commented Aug 15, 2024

Looks good, but we might want to decrease CWmax then also. Currently the absolute maximum delay on LongFast before rebroadcasting is 2^8 * slotTimeMsec = 10.7 seconds, which will become 19.7 seconds. Maybe we can decrease CWmax to 7 such that we get 9.86 seconds?

@thebentern
Copy link
Contributor Author

Looks good, but we might want to decrease CWmax then also. Currently the absolute maximum delay on LongFast before rebroadcasting is 2^8 * slotTimeMsec = 10.7 seconds, which will become 19.7 seconds. Maybe we can decrease CWmax to 7 such that we get 9.86 seconds?

See this is why I added you :-)

@thebentern thebentern merged commit 6f1dae1 into 2.5-changes Aug 15, 2024
4 checks passed
@thebentern thebentern deleted the compute-timeslot branch August 15, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants