Add BMP388 as a new pressure and temp sensor #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
approved these changes
Aug 18, 2024
caveman99
requested changes
Aug 28, 2024
| BMP3XXSensor::BMP3XXSensor() : TelemetrySensor(meshtastic_TelemetrySensorType_BMP3XX, "BMP3XX"){} | ||
|
|
||
| BMP3XXSensor bmp3xxSensor; | ||
|
|
There was a problem hiding this comment.
Please put that in the telemetry init and reference it from there.
caveman99
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this PR adds BMP388 as a new pressure and temperature sensor for the environment module
Its linked to meshtastic/protobuf PR#540 that added the necessary enums to telemetry.proto
This follows pretty much same pattern as other sensors, except that the bmp3xx is intended as a singleton - the reason is that I'm intending to integrate interrupt based reads in future to take advantage of this sensors FIFO (this will be a separate/future PR).
Appreciate your review and any comments, or merge if its ok
Thanks
Dave