Move NeighborInfo interval default to 6 hours (double NodeInfo) #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do 6, twice a day is fine |
|
I agree. Sounds good. So we'll double both the node info broadcast interval default and minimum allowed. |
thebentern
changed the title
|
@thebentern Take a second look at this. I think you accidentally dropped the ms to second scaling, so Neighborinfo happens about 1000 times more often than intended. |
Can confirm, opened a Issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the default MQTT broker traffic management, we've noticed a disproportionate percentage of packets lately are NeighborInfo. Given that this data is really only useful for mesh topology visualizations, I'm proposing moving it to a 6-hour interval, which is double that of its most similar companion: NodeInfo.