Remove heltec-specific gps code from main.cpp

[fifieldt]

After the recent GPS power work we have an clear set of definitions for turning GPS on and off. Rather than manipulating specific heltec tracker-related pins in main setup, the relevant power management code in the GPS module will turn things on/off later as needed.

[fifieldt]

Tested OK on heltec-wireless-tracker .

[fifieldt]

failed unphone build appears unrelated to the patch:
"fatal: unable to access 'https://github.com/meshtastic/esp8266-oled-ssd1306.git/': GnuTLS recv error (-54): Error in the pull function."

[todd-herbert]

That PIN_GPS_EN setup might already be taken care of too by the GPS class, although it'd be worth double checking!

It's a little bit convoluted:

• gps = GPS::createGps() main.cpp, Line 723
• PIN_EN_GPS passed to new_gps instance (via _en_gpio) GPS.cpp Line 1412
• new_gps->up() called GPS.cpp Line 1441
• setPowerState(GPS_ACTIVE); GPS.cpp Line 1015
• writePinEN(true) GPS.cpp Line 828
• pinMode, digitalWrite GPS.cpp Line 886

[fifieldt]

Thanks for checking. Yes, I believe it will be taken care of by the GPS class, I was just attempting to be conservative in changes :) Happy to delete this code from main entirely if that's the desired direction!

[fifieldt]

Just checked - and deleting this code works just fine on the heltec-wireless-tracker.

[fifieldt]

There. Let's be bold.

[todd-herbert]

There. Let's be bold.

Hopefully it's not too bold! It should only impact Wireless Tracker V1.0 (right?) and you've tested that one. 👍

[S5NC]

Can streamline https://github.com/search?q=repo%3Ameshtastic%2Ffirmware+VGNSS_CTRL&type=code