Don't compare nodeDB macaddr to owner.macaddr, because in rare cases … #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that may be unset.
thebentern
approved these changes
Aug 26, 2024
GUVWAF
approved these changes
Aug 27, 2024
geeksville
pushed a commit
to geeksville/Meshtastic-esp32
that referenced
this pull request
Aug 28, 2024
…that may be unset. (meshtastic#4562) Co-authored-by: Ben Meadors <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that may be unset.
Should fix #4559
I'm not aware of any edge cases this would break. As I understand it, we always use the real mac address in our owner object, even if using a generated nodeID.