Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix repeatedly getting a new NodeNum #4670

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Sep 9, 2024

We're comparing ourMacAddr to user.macaddr in pickNewNodeNum(), but owner.macaddr might not yet be set when we copy it to the info of our node in the DB here:

info->user = TypeConversions::ConvertToUserLite(owner);

@GUVWAF GUVWAF requested a review from jp-bennett September 9, 2024 18:52
@thebentern thebentern merged commit 4ed12bf into meshtastic:master Sep 9, 2024
104 checks passed
@GUVWAF GUVWAF deleted the fixNodeNum branch September 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants