Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable remote admin to set/clear fixed positions #4713

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

andrekir
Copy link
Member

@andrekir andrekir commented Sep 15, 2024

This update enables changing and removing fixed_position for remote nodes via set_fixed_position & remove_fixed_position AdminMessages.

When fixed positions were introduced, they were set using standard Position packets, which lacked any way to establish trust in the data. To avoid spoofing any node's position (not just our own) it made sense to block remote fixed positions.

However, with the introduction of secure admin messages, this restriction is no longer necessary.

@jp-bennett
Copy link
Collaborator

This makes sense to me. We no longer have insecure admin, and with the filtering of precise location on MQTT, there's also less chance of abuse there.

@andrekir andrekir force-pushed the remote-fixed_position branch from 51dc745 to d847d9f Compare September 15, 2024 04:03
@thebentern thebentern marked this pull request as ready for review September 17, 2024 11:33
@thebentern thebentern merged commit db4dc88 into master Sep 17, 2024
107 checks passed
@thebentern thebentern deleted the remote-fixed_position branch September 17, 2024 11:50
panaceya pushed a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Sep 20, 2024
@noon92
Copy link
Contributor

noon92 commented Sep 21, 2024

This will allow manual remote entry of gps coords via admin?

@thebentern
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants