Don't use PKC on a non-primary channel unless specifically requested #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Sep 15, 2024
thebentern
reviewed
Sep 15, 2024
| // is not in the local nodedb | ||
| if ( | ||
| // Don't use PKC with Ham mode | ||
| !owner.is_licensed && |
There was a problem hiding this comment.
Wondering if we can encapsulate some of the shared logic for detecting PKC intent for a packet into a method that returns a bool, since the criteria gets fairly lengthy and could grow.
There was a problem hiding this comment.
There's probably a few places through the code where massive if statements could use this treatment.
GUVWAF
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we still have some uses where we want to send to a specific node over a specific channel, this attempts to catch those cases and honor the request. Specifically the admin and serial channel.