Separate GPS and NTP RTCQuality logic and allow GPS time to always set us #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't had time to look into this, but in an ancient issue: #284 (comment) it's noted that ublox puts its last known fix in NMEA messages, which could include an old time. Will try and take a look early next week, but by all means push ahead :) |
jp-bennett
approved these changes
Sep 17, 2024
panaceya
pushed a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #4694
This would allow for the T-Echo in question to be temporarily wrong but eventually correct the time with a time from GPS with a fix.