Expand buffer to MqttClientProxyMessage_size #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
changed the title
thebentern
deleted the
increase-mqttclientproxy-serialization-buffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not technically an MqttClientProxyMessage, expanding the buffer to this size should give us a more room for ServiceEnvelopes with large MeshPackets and long topic names + gateway_ids. We may need to place some long term limitations on size of topic names, because these can get close to the MTU for bluetooth packets. So we'll need to circle back, but this should work for now hopefully.
Closes #4725