-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2C for Heltec Mesh Node T114 #4745
Conversation
acbb66c
to
b6adeae
Compare
f12e67d
to
097e505
Compare
Enabled at compile-time if WIRE_INFERFACES_COUNT defined as 2
SDA: P0.13 SCL: P0.16 Uses bus 1, leaving bus 0 routed to the unpopulated footprint for the RTC (general future-proofing)
SDA=P0.16, SCL=P0.13
097e505
to
7690055
Compare
#ifndef WIRE_INTERFACES_COUNT | ||
// Officially an NRF52 macro | ||
// Repurposed cross-platform to identify devices using Wire1 | ||
#if defined(I2C_SDA1) || defined(PIN_WIRE_SDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todd-herbert shouldn't this be PIN_WIRE_SDA1 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PIN_WIRE1_SDA* rather :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on meshtastic#4745, PIN_WIRE1_SDA is the 'second' wire interface. This pach amends the check to determine whether a device has two wire interfaces should use PIN_WIRE1_SDA, rather than PIN_WIRE_SDA.
Based on #4745, PIN_WIRE1_SDA is the 'second' wire interface. This pach amends the check to determine whether a device has two wire interfaces should use PIN_WIRE1_SDA, rather than PIN_WIRE_SDA.
@fifieldt Ah thank you for spotting that! |
Wondering how were you flashing T114 as there is no model available at web flasher? |
Resolves #4605
Adds an I2C bus, assigned to P0.13 (SDA) and P0.16 (SCL), which are available on the header pins.
This is implemented using a second I2C bus.
Bus 0 retains its original assignment from Heltec: routed to the footprint for an RTC which is not populated on the current hardware version.
Another option would be to simply reassign the pins for the currently unused I2C bus 0.
Is there reason to consider this instead?