Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PhoneAPI rate-limiting of messages on certain ports #4756

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented Sep 18, 2024

Initial PhoneAPI rate-limiting of messages on certain ports to prevent problematic app interactions and give feedback in the form of a client notification to the app. I have personally witnessed the first couple of these:

  1. Traceroute spam: because the user didn't get the response they expected, they continue to click the button and inundate the network with requests which illicit responses congesting the network. We will limit these to every 30 seconds.
  2. Position rate insanity: I have seen rogue BLEManager instances in the iOS firing positions packets in the phone as fast as the Bluetooth protocol will allow. If this happens again, we will have a nice ClientNotification alerting the phone of its spurious behavior. We will limit these to every 5 seconds.

We may eventually add more of these if we get log jammed with TAK packet payloads from ATAK for instance as well.

@thebentern thebentern merged commit 777bcf6 into master Sep 18, 2024
91 of 105 checks passed
@thebentern thebentern deleted the rate-limit-api branch September 18, 2024 15:13
panaceya pushed a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant