-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor flip & color for Heltec T114 and T190 #4786
Honor flip & color for Heltec T114 and T190 #4786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
EDIT: did you upstream the lib changes?
Lib changes were just merged this morning |
092322e
to
cceee51
Compare
I think @HarukiToreda is going to give this a test-run on his T190s later today to check for any unexpected weirdness too 🙏 |
i tested the flip on the T190, works great |
I recall trying a similar change to enable flipping on the Wireless Tracker, which caused it to crash at boot. I think due to the negative display offset for those boards. firmware/variants/heltec_wireless_tracker_V1_0/variant.h Lines 25 to 26 in 18aac0b
In the end I just hard coded and did a build for that specific board to force the flip (I designed my case upside down...) -#define TFT_OFFSET_X 26
-#define TFT_OFFSET_Y -1
+#define TFT_OFFSET_X -26
+#define TFT_OFFSET_Y 1 and changed the I'm not in a position to test this at the moment unfortunately |
* Honor TFT_MESH color if defined for Heltec T114 or T190 * Temporary: point lib_deps at fork of Heltec's ST7789 library For demo only, until ST7789 is merged * Update lib_deps; tidy preprocessor logic
Resolves #4655
Tested working on T114, but needs testing on T190
To-do: update
lib_deps
to point at meshtastic/st7789#1 once mergeddisplay.config.flip_screen
when set by userTFT_MESH
color if defined in variant.h