Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor flip & color for Heltec T114 and T190 #4786

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

todd-herbert
Copy link
Contributor

Resolves #4655
Tested working on T114, but needs testing on T190

To-do: update lib_deps to point at meshtastic/st7789#1 once merged


  • Honors display.config.flip_screen when set by user
  • Honors TFT_MESH color if defined in variant.h

Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

EDIT: did you upstream the lib changes?

@thebentern
Copy link
Contributor

Lib changes were just merged this morning

@todd-herbert
Copy link
Contributor Author

I think @HarukiToreda is going to give this a test-run on his T190s later today to check for any unexpected weirdness too 🙏

@HarukiToreda
Copy link
Contributor

i tested the flip on the T190, works great

@todd-herbert todd-herbert marked this pull request as ready for review September 20, 2024 15:00
@thebentern thebentern merged commit ba31a7c into meshtastic:master Sep 20, 2024
106 checks passed
@AaronJackson
Copy link

I recall trying a similar change to enable flipping on the Wireless Tracker, which caused it to crash at boot. I think due to the negative display offset for those boards.

#define TFT_OFFSET_X 26
#define TFT_OFFSET_Y -1

In the end I just hard coded and did a build for that specific board to force the flip (I designed my case upside down...)

-#define TFT_OFFSET_X 26
-#define TFT_OFFSET_Y -1
+#define TFT_OFFSET_X -26
+#define TFT_OFFSET_Y 1

and changed the tft->setRotation(x) from 3 to 2.

I'm not in a position to test this at the moment unfortunately

mverch67 pushed a commit that referenced this pull request Sep 23, 2024
* Honor TFT_MESH color if defined for Heltec T114 or T190

* Temporary: point lib_deps at fork of Heltec's ST7789 library
For demo only, until ST7789 is merged

* Update lib_deps; tidy preprocessor logic
@todd-herbert todd-herbert deleted the t114-t190-flip-color branch December 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Flip Screen not working on Heltec T114
5 participants