Update classes on protobufs update #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruplelesswizard
force-pushed
the
update-classes-on-protobuf-update
branch
from
e8a7197 to
2026992
Compare
thebentern
approved these changes
Sep 21, 2024
fifieldt
reviewed
Sep 21, 2024
|
IS this correct? the complete submodule path is /protobufs/meshtastic/** The other submodule is meshtestic, the test suite... |
|
Oh, totally not. I'll get a patch up shortly! Thanks for checking @caveman99 |
|
PR closed unintentionally |
scruplelesswizard
force-pushed
the
update-classes-on-protobuf-update
branch
from
ea34add to
b9e9380
Compare
caveman99
approved these changes
Sep 21, 2024
scruplelesswizard
force-pushed
the
update-classes-on-protobuf-update
branch
from
b9e9380 to
2072ebd
Compare
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the update process for Protobufs. Every time a change is made to the
meshtasticsubmodule in a PR, theregen-protos.shwill be run and the changes committed to the PR's branch.This enables class regeneration on Dependabot's PRs and also on any other users PR where
meshtastic/is updated. Additionally it ensures that on any PRs where the protobufs have changed that the classes match.