Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrangle module frames with I2C keyboard #4817

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

todd-herbert
Copy link
Contributor

@todd-herbert todd-herbert commented Sep 22, 2024

Resolves #4681

Background

  • Screen class navigates between frames with left / right keyboard input.
  • Navigation is suppressed when a module frame is shown, to allow canned message text input.

Problem

  • When waypoint module frame is shown, left / right keyboard navigation is suppressed indefinitely: UI is "stuck"

Changes

  • Virtual method added to MeshModule class; allow modules to explicitly state when handling keyboard input.
  • When not handling keyboard input, allow normal left / right UI keyboard navigation, even on module frames.
  • CardKB key-combo to dismiss Text Message and Waypoint frames, for convenience.
    Provisionally assigned to Fn + Delete

src/input/kbI2cBase.cpp Outdated Show resolved Hide resolved
@todd-herbert todd-herbert marked this pull request as draft September 22, 2024 14:44
@todd-herbert todd-herbert changed the title Mesh Modules specify when handling keyboard input Wrangle module frames with I2C keyboard Sep 23, 2024
@todd-herbert todd-herbert marked this pull request as ready for review September 23, 2024 12:32
@todd-herbert
Copy link
Contributor Author

todd-herbert commented Sep 23, 2024

  • CardKB key-combo to dismiss Text Message and Waypoint frames, for convenience.

Is everyone happy with this mapped to Fn + Delete? No objections to changing it if you'd prefer something different.

@HarukiToreda
Copy link
Contributor

y with this mapped to Fn + Delete? No objections to changing it if you'd prefer something different.

yeah looks like the intuitive shortcut combination that will be easy to remember.

@thebentern thebentern merged commit d1138d5 into meshtastic:master Sep 25, 2024
107 checks passed
@todd-herbert todd-herbert deleted the cardkb-waypoint branch December 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Waypoint breaks Cardkb and Tdeck left and right buttons/trackball
3 participants