Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Panel_ILI9342 to TFTDisplay.cpp #4822

Merged
merged 19 commits into from
Oct 4, 2024
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Sep 22, 2024

@lboue lboue marked this pull request as ready for review September 23, 2024 07:18
@fifieldt
Copy link
Contributor

Hi,

looking quickly at the driver code in TFTDisplay.cpp, the code for ILI9341_DRIVER and ILI9342_DRIVER looks almost identical. Though, I could be missing something!

Would you consider re-using some of the existing code there?

@lboue
Copy link
Contributor Author

lboue commented Sep 23, 2024

Hi,

looking quickly at the driver code in TFTDisplay.cpp, the code for ILI9341_DRIVER and ILI9342_DRIVER looks almost identical. Though, I could be missing something!

Would you consider re-using some of the existing code there?

OK, I'll try to factorize the code.

@lboue
Copy link
Contributor Author

lboue commented Oct 3, 2024

Hi,
looking quickly at the driver code in TFTDisplay.cpp, the code for ILI9341_DRIVER and ILI9342_DRIVER looks almost identical. Though, I could be missing something!
Would you consider re-using some of the existing code there?

OK, I'll try to factorize the code.

Is it OK now?

@fifieldt
Copy link
Contributor

fifieldt commented Oct 4, 2024

Thanks so much for doing that. Taking a look.

@thebentern thebentern merged commit e7cfada into meshtastic:master Oct 4, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants