Refactor and consolidate time window logic #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
reviewed
Sep 23, 2024
|
This is a good change. I can sense there's a future vision here ... |
fifieldt
reviewed
Sep 23, 2024
fifieldt
force-pushed
the
consolid-window
branch
from
704259c to
bfce419
Compare
|
@thebentern , I pushed a commit that fixed the syntax error and removed some of the unused variables. A few comments in the previous patch you might still like to take a look at. |
fifieldt
force-pushed
the
consolid-window
branch
from
bfce419 to
10c7c81
Compare
fifieldt
reviewed
Sep 23, 2024
fifieldt
force-pushed
the
consolid-window
branch
from
10c7c81 to
1c35952
Compare
fifieldt
reviewed
Sep 23, 2024
fifieldt
force-pushed
the
consolid-window
branch
from
1c35952 to
d2e32d9
Compare
thebentern
changed the title
There was a brace in src/mesh/RadioLibInterface.cpp that was breaking compile on some architectures. Additionally, there were some brace errors in src/modules/Telemetry/AirQualityTelemetry.cpp src/modules/Telemetry/EnvironmentTelemetry.cpp src/mesh/wifi/WiFiAPClient.cpp Move throttle include in WifiAPClient.cpp to top. Add Default.h to sleep.cpp rest of files just remove unused now variables.
fifieldt
force-pushed
the
consolid-window
branch
from
2f353cc to
31a2f75
Compare
mverch67
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Refactor and consolidate windowing logic * Trunk * Fixes * More * Fix braces and remove unused now variables. There was a brace in src/mesh/RadioLibInterface.cpp that was breaking compile on some architectures. Additionally, there were some brace errors in src/modules/Telemetry/AirQualityTelemetry.cpp src/modules/Telemetry/EnvironmentTelemetry.cpp src/mesh/wifi/WiFiAPClient.cpp Move throttle include in WifiAPClient.cpp to top. Add Default.h to sleep.cpp rest of files just remove unused now variables. * Remove a couple more meows --------- Co-authored-by: Tom Fifield <[email protected]>
|
@thebentern There are a number of places where 'seconds' are passed in rather than 'milliseconds' (NeighborInfo is one) in this commit. |
|
@gitbisector would you mind creating an issue bug? |
|
Done: #4935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.