Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename message length headers and set payload max to 255 #4827

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Rename message length headers and set payload max to 255 #4827

merged 3 commits into from
Sep 23, 2024

Conversation

jp-bennett
Copy link
Collaborator

As per Semtech's documentation, the payload max length is actually 255 bytes. https://www.mouser.com/datasheet/2/761/sx1276-1278113.pdf page 65

@fifieldt
Copy link
Contributor

fifieldt commented Sep 23, 2024 •
edited
Loading

Guess what? With this, my SX1276 Tbeam can now send messages to the LR1110-based T-1000E.

Unfortunately it looks like messages were going via another node.

@fifieldt fifieldt mentioned this pull request Sep 23, 2024
Open
2 tasks
fifieldt
fifieldt approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, and based on a small amount of testing appears to improve things for my devices.

However, will leave merge to people who are more versed in radio things ;)

@jp-bennett
Copy link
Collaborator Author

Guess what? With this, my SX1276 Tbeam can now send messages to the LR1110-based T-1000E.

Wait what? ... what?

@fifieldt fifieldt mentioned this pull request Sep 23, 2024
Closed
@fifieldt
Copy link
Contributor

fifieldt commented Sep 23, 2024 •
edited
Loading

Also, T114 doesn't crash on sending long messages now.

@thebentern thebentern requested a review from GUVWAF September 23, 2024 11:33
GUVWAF
GUVWAF reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@GUVWAF GUVWAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

src/mesh/RadioInterface.h Show resolved Hide resolved
@thebentern thebentern merged commit fa1cc59 into master Sep 23, 2024
17 of 105 checks passed
@thebentern thebentern deleted the proper-length-check branch September 23, 2024 14:20
mverch67 pushed a commit that referenced this pull request Sep 23, 2024
@jp-bennett @caveman99 @mverch67
Rename message length headers and set payload max to 255 (#4827)
d91cda9 
* Rename message length headers and set payload max to 255

* Add MESHTASTIC_PKC_OVERHEAD

* compare to MESHTASTIC_HEADER_LENGTH

---------

Co-authored-by: Thomas Göttgens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUVWAF GUVWAF GUVWAF left review comments

@thebentern thebentern thebentern approved these changes

@fifieldt fifieldt fifieldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jp-bennett @fifieldt @thebentern @GUVWAF @caveman99