Teardown bluetooth phoneAPI better and fix client notification issue #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
approved these changes
Sep 23, 2024
jp-bennett
force-pushed
the
phoneapi-close-ondisconnect
branch
from
103cb9b to
439782d
Compare
thebentern
force-pushed
the
phoneapi-close-ondisconnect
branch
from
439782d to
80a995f
Compare
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4388
Adding a ton of explicit tearing down seems to improve stability a lot between BLE disconnects.
Also fixed an inconsistency in how we were handling ClientNotification vs other FromRadio variants with their own queues
Tested on Heltec V3 and RAK-4631.
PS: Also hoping this has a side-effect of fixing some of the nodedb / config wipes on BLE disconnect and reconnect cycles sporadically.