Potential fix for bad Rx performance on T1000-E #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Let's try it. setDioAsRfSwitch is godmode only btw... :-) I just went by the documentation. |
caveman99
approved these changes
Sep 27, 2024
|
@caveman99 Can you try if this doesn't break on another LR11x0 dev board you have? |
I will tomorrow morning. Also i wanna put the Switch matrix into variant.h or next to it for each board and just leave the default in the firmware code. Not have a giant ifdef construct there. |
thebentern
approved these changes
Sep 28, 2024
seems to work fine with all boards, can you review my changes? |
thebentern
approved these changes
Sep 28, 2024
|
Looks good and clean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the part of the issue from #4775 where it only hears SX126x/LR11x0 radios that are close.
While the RadioLib example mentions
setRfSwitchTable()should be called beforebegin(), we calledsetDioAsRfSwitch()(which gets called insidesetRfSwitchTable()) at this place before 2f0c19e.