Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore seen phoneapi packets #4888

Merged
merged 11 commits into from
Sep 28, 2024
Merged

Ignore seen phoneapi packets #4888

merged 11 commits into from
Sep 28, 2024

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented Sep 27, 2024

Turns out some of the Phone API spam is actually replaying the same packets. This completely silences the Rate limit notification spam on my devices.

@GUVWAF
Copy link
Member

GUVWAF commented Sep 27, 2024

Do we know why it is replaying the same packets?

I'm not sure if all clients actually set a packet ID or leave it 0, which would not work with this.

@thebentern
Copy link
Contributor Author

Do we know why it is replaying the same packets?

No, I have been trying to figure out if it's somehow related to the push / pull system of notify and read value from characteristic or something going haywire in the bluetooth stack in iOS. I have not reproduced it on the Android side, but I have not done much testing there.

I'm not sure if all clients actually set a packet ID or leave it 0, which would not work with this.

I know iOS is generating packet IDs, but I'll double check if Android as well.

@jp-bennett
Copy link
Collaborator

Or just make an exception for packets with num of 0

@thebentern thebentern requested a review from GUVWAF September 27, 2024 22:44
@thebentern
Copy link
Contributor Author

Or just make an exception for packets with num of 0

Easy addition. I'll whip this up

@thebentern thebentern merged commit 8efc15f into master Sep 28, 2024
38 checks passed
@caveman99 caveman99 deleted the ignore-seen-phoneapi-packets branch October 16, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants