Only log "Setting DIO2 as RF switch" when doing so and fix battery level #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do it. Also, if there's an error setting DIO2, log the error code.
…evel if there's no Lipo sensor, just have lipoInit return false. The forwarding didn't work because it never called analogInit.
GUVWAF
changed the title
|
This indeed fixes battery level values of @dhskinner can you double-check if the MAX17048 still works for you when using this? |
|
Oops, I'm not good at GitHub; I didn't actually intend for the battery level commit to be included in this PR. I guess I should've made the changes on separate branches? |
|
@dahanc No worries, since the first one is pretty small, I think it's okay like this. |
caveman99
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…do it. Also, if there's an error setting DIO2, log the error code.
Super minor, but I mentioned this in Discord a few days ago, and it seemed like @jp-bennett thought it was a good idea?