Allow for better target level Radiolib exclude plumbing #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice, this doesn't make a huge size difference in the application binary, but it's probably a good approach.
I went ahead and knocked out RAK4631 because it is almost out of flash space and has a single radio option.
Before:
After:
RAM: [== ] 22.5% (used 56036 bytes from 248832 bytes)
Flash: [==========] 96.5% (used 786204 bytes from 815104 bytes)
RAM: [== ] 22.5% (used 55940 bytes from 248832 bytes)
Flash: [==========] 96.4% (used 785692 bytes from 815104 bytes)
``
Download firmware-2.5.4.acb8c83.zip. This artifact will be available for 90 days from creation
the application binary, but it's probably a good approach.I went ahead and knocked out RAK4631 because it is almost out of flash space and has a single radio option.
Before:
After:
RAM: [== ] 22.5% (used 56036 bytes from 248832 bytes)
Flash: [==========] 96.5% (used 786204 bytes from 815104 bytes)
RAM: [== ] 22.5% (used 55940 bytes from 248832 bytes)
Flash: [==========] 96.4% (used 785692 bytes from 815104 bytes)