Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserPrefs - Preconfigure up to 3 channels, GPS Mode #4930

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

medentem
Copy link
Contributor

@medentem medentem commented Oct 2, 2024

  • Moved LoRa setting actions to their own function initDefaultLoraConfig
  • Added USERPREFS_CHANNELS_TO_WRITE (currently max of 3)
  • Added the other userprefs for PSK, Name and Precision for the additional 2 channels
  • Added USERPREFS_CONFIG_GPS_MODE

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@medentem medentem changed the title UserPrefs - Preconfigure up to 3 channels UserPrefs - Preconfigure up to 3 channels, GPS Mode Oct 3, 2024
@thebentern thebentern requested a review from jp-bennett October 4, 2024 11:29
@fifieldt fifieldt merged commit 0952d1b into meshtastic:master Oct 6, 2024
45 checks passed
@mike6789
Copy link

Why aren't more settings included here? This seems half-baked. For example, device role, bluetooth enabled/disabled, etc etc

@fifieldt
Copy link
Contributor

@mike6789, indeed! This one's a new feature - it's growing gradually :) We have big plans. Discussions in discord and further efforts in this area most welcome :)

@jp-bennett
Copy link
Collaborator

Why aren't more settings included here? This seems half-baked. For example, device role, bluetooth enabled/disabled, etc etc

Find something you want, that's missing, and make a PR! Or open an issue asking for it. Limited developer time, and near infinite work to be done, and all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants