Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Userprefs Timezone String, to be replaced in the web flasher #4938

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

jp-bennett
Copy link
Collaborator

No description provided.

@jp-bennett jp-bennett requested a review from thebentern October 3, 2024 20:07
@jp-bennett jp-bennett merged commit befc2ec into master Oct 4, 2024
46 checks passed
@jp-bennett jp-bennett deleted the tz_userprefs branch October 4, 2024 01:51
@GUVWAF
Copy link
Member

GUVWAF commented Oct 4, 2024

Maybe we can do the same with the BUILD_EPOCH macro? Currently it's still rebuilding the whole firmware every time, because this changes in the platformio.ini file.

@thebentern
Copy link
Contributor

Maybe we can do the same with the BUILD_EPOCH macro? Currently it's still rebuilding the whole firmware every time, because this changes in the platformio.ini file.

GENIUS! I've been almost regretting the mechanism for that one because I'm commenting it out locally to avoid rebuilds. 🤣

@thebentern
Copy link
Contributor

Actually I think I have a quick way of fixing this the BUILD_EPOCH. PR incoming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants