Possibly forward PKC DMs over MQTT

[jp-bennett]

No description provided.

[ianmcorvidae]

This looks like the fix for the spot I was looking at (unless we need to do any additional guards when MQTT encryption is turned off?); haven't dug through completely to be sure it's the only spot. We may need to mark the packet as pki_encrypted (even though we're not sure it is) with how the MQTT code is currently written, since I think it chooses the publish topic and such based on that. Or push similar checks to this into there as well

[jp-bennett]

@ianmcorvidae I think this logic is already present in MQTT itself.

[JohnathonMohr]

@jp-bennett just judging from the title - do you expect this to fix #5000? Or is this unrelated?

[jp-bennett]

@jp-bennett just judging from the title - do you expect this to fix #5000? Or is this unrelated?

I believe this is related, yes. Please let me know if this fixes your issue.

[GUVWAF]

@jp-bennett I don't think this will do anything, it would only lead to:

firmware/src/mqtt/MQTT.cpp

Lines 540 to 542 in ad8747d

	if (!mp.pki_encrypted) {
	if (mp_decoded.which_payload_variant != meshtastic_MeshPacket_decoded_tag) {
	LOG_CRIT("MQTT::onSend(): mp_decoded isn't actually decoded\n");

Because if it was already decoded and it was PKC, pki_encrypted would be set.

Edit: Well, mp is the still-encrypted copy of the packet! So this would never have pki_encrypted set when receiving it.