Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove newline from logging statements. #5022

Merged
merged 15 commits into from
Oct 14, 2024
Merged

remove newline from logging statements. #5022

merged 15 commits into from
Oct 14, 2024

Conversation

caveman99
Copy link
Member

still looking for stuff, WIP

Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tagged a place where we're printing a lot of characters in a loop and putting in a linebreak between the characters will make logs a lot less useful :)

src/gps/GPS.cpp Show resolved Hide resolved
@jp-bennett
Copy link
Collaborator

As a separate effort, there are likely a bunch of these log statements that can be disabled for normal use.

@jp-bennett
Copy link
Collaborator

Hmm. For log lines without any variable substitution, could we just use an enum?

@caveman99 caveman99 marked this pull request as ready for review October 12, 2024 14:35
@caveman99 caveman99 marked this pull request as draft October 12, 2024 15:13
platformio.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed a dozen files in the code that are ones I'm familar with and this looks flawless.

src/Power.cpp Outdated Show resolved Hide resolved
@caveman99 caveman99 marked this pull request as ready for review October 13, 2024 15:35
@caveman99 caveman99 requested a review from fifieldt October 13, 2024 15:35
@fifieldt fifieldt merged commit 05e4a63 into master Oct 14, 2024
48 checks passed
@caveman99 caveman99 deleted the no-new-lines branch October 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants