Ws85 updates : set want_ack, high_priority, add temperature. #5052
Conversation
add temperature add wantack add high_priority set lull to 0 if never set. add the has_FIELD_NAME lines to ws85
src/modules/SerialModule.cpp
Outdated
| @@ -252,7 +252,8 @@ void SerialModule::sendTelemetry(meshtastic_Telemetry m) | |||
| pb_encode_to_bytes(p->decoded.payload.bytes, sizeof(p->decoded.payload.bytes), &meshtastic_Telemetry_msg, &m); | |||
| p->to = NODENUM_BROADCAST; | |||
| p->decoded.want_response = false; | |||
| p->priority = meshtastic_MeshPacket_Priority_RELIABLE; | |||
| p->want_ack = true; | |||
| p->priority = meshtastic_MeshPacket_Priority_MAX; | |||
There was a problem hiding this comment.
Please don't set it higher than ACK, because those need to get priority always to avoid excessive retransmissions and flooding. You could use meshtastic_MeshPacket_Priority_HIGH.
There was a problem hiding this comment.
also what about framing this change with device.role.sensor? because that would be the appropriate role for this kind of packets.
E.G. use 'reliable' and no want_ack from all other roles...
There was a problem hiding this comment.
I changed to high from max. The sensor role could work but the ws85 sensor node can't go to sleep or it'll miss the serial wind data that comes in every 2 seconds. Sensor role could muck that up i think.
There was a problem hiding this comment.
Sensor role should only sleep if you have power.is_power_saving enabled
There was a problem hiding this comment.
also what about framing this change with device.role.sensor? because that would be the appropriate role for this kind of packets.
E.G. use 'reliable' and no want_ack from all other roles...
are you proposing that I check for sensor_role here and only set want_ack and high priority if sensor_role is set ?
tavdog
changed the title
For more reliable data transmission, set want_ack and priority_max in the packet. Wind data only gets sent every 5 minutes and any node with ws85 enabled will most likely be a remote weather node with no other purpose than to send out the wind telemetry.
Also add parse temperature from the WS85 and add it to the telemetry packet.