Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Untested. Need to make sure this is getting ignored by the PKC logic... it's probably not |
|
Maybe we could add an |
|
I think when this is applied, we can also relax the default and minimum broadcast intervals again? E.g. 30 min. and 15 min., respectively, would be OK if it's only going to MQTT and the PhoneAPI. |
fifieldt
force-pushed
the
broadcast-nolora-neighbors
branch
from
71bd069 to
3fb4451
Compare
|
I don't think we should relax anything, this thing is still a traffic monster, these packets will pop back up over mqtt. Why save this? |
panaceya
added a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Oct 21, 2024
* Add DIO2_AS_RF_SWITCH to pinedio prefilled config. * Add `-p` flag (meshtastic#5093) Add the `-p` to the `mkdir` so it doesn't fail when the folder already exists Co-authored-by: Ben Meadors <[email protected]> * Revert "Permanently engage !CTRL" * Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module (meshtastic#5087) * Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module * isBroadcast * Trunkt * Move 115200 baud GNSS probe earlier (meshtastic#5101) * Move 115200 baud GNSS probe earlier * Even more optimized! * Fix GPS_DEBUG output (meshtastic#5100) After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable. Patch uses local strings and appends to collate and then print in the right places. Fixes meshtastic#5099 Co-authored-by: Ben Meadors <[email protected]> * Wide_Lora uses 12 symbols to be compatible with SX1280 * Fix rebroadcasting encrypted packets when `KNOWN_ONLY` or `LOCAL_ONLY` is used (meshtastic#5109) --------- Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: madeofstown <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: GUVWAF <[email protected]>
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
…dule (#5087) * Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module * isBroadcast * Trunkt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5082