Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RFC 3927 IP address space to private IP checks #5115

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rbrtio
Copy link
Contributor

@rbrtio rbrtio commented Oct 21, 2024

Per the comments of #5098 add the RFC 3927 IP address block (169.254.0.0/16), also referred to as IPIPA, to the private address checks for MQTT functionality.

RFC3927 Reference

Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, appreciate your dedication to contributing even in the face of negative feedback in your first patch!

@fifieldt fifieldt merged commit a4705d2 into meshtastic:master Oct 21, 2024
47 checks passed
caveman99 pushed a commit that referenced this pull request Nov 3, 2024
Add the RFC 3927 IP address block (169.254.0.0/16), also referred to as IPIPA, to the private address checks for MQTT functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants