Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meshtasticd.service #5118

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update meshtasticd.service #5118

merged 1 commit into from
Oct 22, 2024

Conversation

yNosGR
Copy link
Contributor

@yNosGR yNosGR commented Oct 21, 2024

Adding restart on service failure with 3 seconds between restart to stop fast restart loops.
Adding StartLimitBurst and StartLimitInterval to limit it to 5 restarts in 200 seconds.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@thebentern thebentern requested a review from jp-bennett October 21, 2024 15:56

[Service]
User=root
Group=root
Type=simple
ExecStart=/usr/sbin/meshtasticd
Restart=always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps on-failure makes more sense than always?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would need an audit of whether we properly use return codes for all of our exit conditions.

Adding restart on service failure with 3 seconds between restart to stop fasst restart loops. Adding StartLimitBurst to limit it to 5 restarts in 200 seconds.
@thebentern thebentern merged commit 3f1c86f into meshtastic:master Oct 22, 2024
34 checks passed
caveman99 pushed a commit that referenced this pull request Nov 3, 2024
Adding restart on service failure with 3 seconds between restart to stop fasst restart loops. Adding StartLimitBurst to limit it to 5 restarts in 200 seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants