Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Board] Support Heltec LoRa32 v3.2 charge status #5130

Closed
wants to merge 1 commit into from
Closed

[Board] Support Heltec LoRa32 v3.2 charge status #5130

wants to merge 1 commit into from

Conversation

HarrisonW
Copy link

Tested with `pio run -e heltec-v3_2`` and uploading to a v3.2 board. Now shows battery status properly.

fixes #5127

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fifieldt fifieldt force-pushed the master branch 2 times, most recently from bf43aac to 1bd74ff Compare October 24, 2024 04:09
fifieldt
fifieldt approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the appropriate fix for now

@thebentern thebentern marked this pull request as draft October 24, 2024 10:16
@thebentern
Copy link
Contributor

Thanks for the PR. Before we go down this route, I have something sneaky I want to try to hopefully not need two separate variants.

@caveman99 caveman99 added high-priority Issues that affect core functionality or are "show stoppers" hardware-support Add hardware support for new devices or modules labels Oct 26, 2024
@rcarteraz
Copy link
Member

Thanks for the PR. Before we go down this route, I have something sneaky I want to try to hopefully not need two separate variants.

That would definitely be the better option if possible.

@HarrisonW @caveman99
[Board] Support Heltec LoRa32 v3.2 charge status
79a0968 
Tested with `pio run -e heltec-v3_2`` and uploading to a v3.2 board. Now shows battery status properly.
@caveman99
Copy link
Member

Waiting for the sneak to sneak ... :-)

@caveman99 caveman99 added the pinned Exclude from stale processing label Oct 30, 2024
@HarrisonW
Copy link
Author

#5196 does this better, but will keep this open if that one doesn't work

@meekowai
Copy link

meekowai commented Nov 2, 2024 •
edited
Loading

I built my own fw 2 days ago with suggested change
17 #define ADC_CTRL_ENABLED HIGH
based of master branch and noticed today the board won't keep charging the battery.
Even tho the cable is plugged in, the battery stars to drain. LED is off. Or is it only issue with proper status indication?
Is #5196 fixing this as well?

@thebentern thebentern closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifieldt fifieldt fifieldt approved these changes

Assignees
No one assigned
Labels
hardware-support Add hardware support for new devices or modules high-priority Issues that affect core functionality or are "show stoppers" pinned Exclude from stale processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Board]: Heltec WiFi LoRa32 V3.2 - new version shows incorrect charge status
7 participants
@HarrisonW @CLAassistant @thebentern @rcarteraz @caveman99 @meekowai @fifieldt