Icarus - Custom PCB #5155
Merged
Icarus - Custom PCB #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
approved these changes
Oct 26, 2024
variants/icarus/variant.h
Outdated
| @@ -0,0 +1,30 @@ | |||
| // Icarus has a 1.3 inch OLED Screen | |||
| #define USCREEN_SSD106 | |||
There was a problem hiding this comment.
That looks like a typo. you sure?
There was a problem hiding this comment.
it was in the seeedstudio esp32s3 variant.h and im using a similar screen, the firmware works so no issues there haha
There was a problem hiding this comment.
That is not really authoritative ... :-)
I looked it up, that's definitely a typo. Should be SCREEN_SSD1306 (or any other screen model, these are usually auto detected) and you define them only if you have problem with autodetect. May be the reason it works for you despite the typo.
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
* added Icarus * added Icarus * Update platformio.ini * Fixed I2C ports * Update variant.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Hopefully I have sufficiently fixed the issues from before :) Changed it to private hardware and removed my protobufs.