Don't skip GPS serial speeds, and always land on GPS_BAUDRATE #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
force-pushed
the
GPS-search-tweak
branch
from
9d45a23 to
b457f8e
Compare
fifieldt
approved these changes
Nov 1, 2024
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
* Don't skip GPS serial speeds, and always land on GPS_BAUDRATE * Update log message to match. * print the value instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tiny tweaks to GPS search. First, it really looks like the speedSelect skip can trigger each time through the loop of serialSpeeds, which means that we could skip some speeds every time. And second, rather than just always defaulting to 9600 after not finding anything, we should default to the defined speed in GPS_BAUDRATE. (Credit to Technologyman00 on Discord for that idea)