Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass#2: Lots more savings in logs and string reduction surgery #5251

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Pass#2: Lots more savings in logs and string reduction surgery #5251

merged 4 commits into from
Nov 4, 2024

Conversation

thebentern
Copy link
Contributor

  1. Remove "Module" suffix
  2. Don't be so pedantic about verb case ;-)
  3. Lots of misc removals and reductions

@fifieldt
Copy link
Contributor

fifieldt commented Nov 4, 2024

Read through the log changes. Not sure if there are any impacts of removing the module suffix in the thread stuff, but I assume it works :)

caveman99
caveman99 approved these changes Nov 4, 2024
View reviewed changes
src/main.cpp Show resolved Hide resolved
src/main.cpp Show resolved Hide resolved
@thebentern
Copy link
Contributor Author

Read through the log changes. Not sure if there are any impacts of removing the module suffix in the thread stuff, but I assume it works :)

Mostly shorter print statements. The longer ones kick out the padding so much that it's unhelpful :D

@thebentern thebentern merged commit 50dac38 into master Nov 4, 2024
48 checks passed
@thebentern thebentern deleted the more-reduction branch November 4, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifieldt fifieldt fifieldt approved these changes

@caveman99 caveman99 caveman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebentern @fifieldt @caveman99