Only PKC encrypt when packet originates from us

[GUVWAF]

This should fix the issue when a node using firmware <2.5 sends a direct message to a 2.5 node, and it hops through another 2.5 node. Currently, as reported on Discord, the intermediate 2.5 node would PKC encrypt it with its own public key when the DM was received on its primary channel, because it could decrypt it and then before rebroadcasting, this passes:

firmware/src/mesh/Router.cpp

Lines 495 to 496 in 9821909

	// Don't use PKC if it's not explicitly requested and a non-primary channel is requested
	!(p->pki_encrypted != true && p->channel > 0) &&

Only when a packet originates from us, we should PKC encrypt.

[psyh0x]

you meant to say its sent from 2.4 -> 2.5 -> 2.5
the message will not be received on the last 2.5 node.

[GUVWAF]

No, right? In your case it's sent from a 2.4 device, then goes through a 2.5 device and received by a 2.5 node.

[psyh0x]

Exactly

…

On 6 Nov 2024, at 22:42, GUVWAF ***@***.***> wrote: No, right? In your case it's sent from a 2.4 device, then goes through a 2.5 device and received by a 2.5 node. — Reply to this email directly, view it on GitHub <#5267 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJMF27EMDHRDXTPT5KIXVLTZ7J5KXAVCNFSM6AAAAABRJTVZ4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQG4ZTQMZSGI>. You are receiving this because you commented.