copy the has_relative_humidity value to full telem packet from AHTX0 packet #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for when AHTX0+BMP280 module detected: using temp from BMP280 and humy from AHTX0. Humidity is pulled from AHTX0 and value is copied into the full telemetry packet but the has_relative_humidity flag was not copied over and so the humi value is skipped in protobuf encoding.
I copied the value from the AHTX0 packet instead of setting to true explicity. Don't think that matters though.
mentioned here #5139