Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rak10701 (rak wismeshtap) optimization #5280

Merged
merged 18 commits into from
Nov 11, 2024

Conversation

DanielCao0
Copy link
Contributor

@DanielCao0 DanielCao0 commented Nov 8, 2024

  • Improve the processing speed of virtual keyboards
  • Fixed turned off gps caused the screen not to display
  • Changed the default screen sleep time to 30s
  • Rename platform rak10701 -> rak wismeshtap

DanielCao0 and others added 2 commits November 8, 2024 15:01
* Improve the processing speed of virtual keyboards
* Remove the disable GPS feature, as it would interfere with the normal use of TFT
* Changed the default screen sleep time to 30s
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@DanielCao0 DanielCao0 closed this Nov 8, 2024
@DanielCao0 DanielCao0 reopened this Nov 8, 2024
DanielCao0 and others added 5 commits November 8, 2024 17:29
* Improve the processing speed of virtual keyboards
* Remove the disable GPS feature, as it would interfere with the normal use of TFT
* Changed the default screen sleep time to 30s
platformio.ini Outdated Show resolved Hide resolved
@DanielCao0
Copy link
Contributor Author

DanielCao0 commented Nov 9, 2024

This is an urgent merge request, hope to get help, thank you . @fifieldt @thebentern

@DanielCao0 DanielCao0 changed the title rak10701 optimization rak10701 (rak wismeshtap) optimization Nov 9, 2024
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and confirmed it only affected the particular device.

There may be a less invasive way to perform the exclusions, but since the committer labeled it urgent I would be OK merging this and performing cleanup later.

@DanielCao0
Copy link
Contributor Author

DanielCao0 commented Nov 10, 2024

I reviewed the code and confirmed it only affected the particular device.

There may be a less invasive way to perform the exclusions, but since the committer labeled it urgent I would be OK merging this and performing cleanup later.

I found a issue, uf2 of master 10701 can not be used, my branch is also the same issue, is it because the firmware of nrf52 is too large? The 4631 master branch does not have this issue@fifieldt . But hex is normal

@DanielCao0
Copy link
Contributor Author

a73fbdaecce5d79a74d7e31c754bcbe
Whether uf2 cannot be used has much to do with flash ?

@DanielCao0
Copy link
Contributor Author

DanielCao0 commented Nov 10, 2024

a73fbdaecce5d79a74d7e31c754bcbe Whether uf2 cannot be used has much to do with flash ?

Fixed . uf2 doesn't work because the firmware is too big
Flash: [==========] 98.3% (used 801504 bytes from 815104 bytes)
-DMESHTASTIC_EXCLUDE_WIFI=1
-DMESHTASTIC_EXCLUDE_EXTERNALNOTIFICATION=1
-DMESHTASTIC_EXCLUDE_WAYPOINT=1

98.3% work

@DanielCao0 DanielCao0 closed this Nov 10, 2024
@DanielCao0 DanielCao0 deleted the wismeshtap_4.5.12 branch November 10, 2024 04:56
@DanielCao0 DanielCao0 restored the wismeshtap_4.5.12 branch November 10, 2024 04:59
@DanielCao0 DanielCao0 reopened this Nov 10, 2024
@caveman99 caveman99 merged commit 6eba278 into meshtastic:master Nov 11, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants